Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stratconn 3718] Add Remove Profile #1994

Merged
merged 4 commits into from
Apr 23, 2024
Merged

[Stratconn 3718] Add Remove Profile #1994

merged 4 commits into from
Apr 23, 2024

Conversation

harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented Apr 16, 2024

Add Remove Profile action to klaviyo which works with rETL and mimics Remove Profile from List (Engage).

JIRA -> STRATCONN-3718

Testing

Test Completed Successfully in staging.
Screenshot 2024-04-16 at 11 26 56 AM

RETL
Mapping
Screenshot 2024-04-16 at 11 53 18 AM

Screenshot 2024-04-16 at 11 53 27 AM

Result
Screenshot 2024-04-16 at 11 52 38 AM

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment


const action: ActionDefinition<Settings, Payload> = {
title: 'Remove Profile',
description: 'Remove profile from list',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the description to look different from RemoveProfileFromList Actions. 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action is exactly same as Remove profile from list and is added to support RETL. I think same description should be ok?

AnkitSegment
AnkitSegment previously approved these changes Apr 17, 2024
Copy link
Contributor

@AnkitSegment AnkitSegment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge latest changes from master to your branch? Couple of tests are failing.

Otherwise, the PR LGTM ✨

@joe-ayoub-segment joe-ayoub-segment merged commit de555ec into main Apr 23, 2024
24 of 27 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the STRATCONN-3718 branch April 23, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants