-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stratconn 3718] Add Remove Profile #1994
Conversation
|
||
const action: ActionDefinition<Settings, Payload> = { | ||
title: 'Remove Profile', | ||
description: 'Remove profile from list', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the description to look different from RemoveProfileFromList Actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The action is exactly same as Remove profile from list and is added to support RETL. I think same description should be ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you merge latest changes from master to your branch? Couple of tests are failing.
Otherwise, the PR LGTM ✨
428e116
to
d82ba39
Compare
0e39598
to
d82ba39
Compare
Add Remove Profile action to klaviyo which works with rETL and mimics Remove Profile from List (Engage).
JIRA -> STRATCONN-3718
Testing
Test Completed Successfully in staging.
RETL
Mapping
Result