[KAMELEOON] added type property for every event

[akalyuzhnyi]

The Kameleoon cloud destination.

Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

added type property for every event

[joe-ayoub-segment]

Hi @akalyuzhnyi this PR doesn't look right. Didn't we just deploy some new Actions for the Kameleoon Destination via this PR? #1974

Looks like this PR is doing something similiar?

[akalyuzhnyi]

Hello @joe-ayoub-segment

Sorry there was wrong MR, now everything is ok

I forgot to add types for the events, could you review please?

[joe-ayoub-segment]

Hi @akalyuzhnyi the change mostly looks good. However you need to be super careful about adding a new 'required' field. Please see comment above.

If you have customers already using this Integration, I would make the type field optional.

[akalyuzhnyi]

yes, same type like before for logEvent :)

[joe-ayoub-segment]

yes, same type like before for logEvent :)

hi @akalyuzhnyi - if I deploy the code as it is now it will break any data collection for customers who are already using it.
Is this OK for you?

[akalyuzhnyi]

yes, same type like before for logEvent :)

hi @akalyuzhnyi - if I deploy the code as it is now it will break any data collection for customers who are already using it. Is this OK for you?

Ok for me

[joe-ayoub-segment]

note: PR deployed on Tuesday this week

[akalyuzhnyi]

note: PR deployed on Tuesday this week

Hello! everything works fine, thank you!