Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release Scripts] Fix changelog formatting and bump checkout/setup-node github action versions #2052

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented May 22, 2024

This PR makes some general improvements to scripts used in release.

The changes include

  • Table formatting issue in release/changelog description. Some git commits contain | breaking the markdown. table rendering of changelog. This PR title had a | that broke the table formatting.
    Eg;
Screenshot 2024-06-24 at 12 22 13 PM
  • Updates checkout and setup-node actions to use the latest v4 version. v3 uses node 16 and it'll be deprecated soon by github actions runtime. The release notes (checkout and setup-node) of these github actions indicate that there were no major changes.
    Warning message from CI
    image

Testing

Testing complete successfully in local and via CI.

  • The checkout v4 and setup-node v4 steps succeeded in the current PR
    image

@varadarajan-tw varadarajan-tw changed the title [Release Notes] Escape markdown special characters [Release Scripts] Improvements to release scripts Jun 24, 2024
@varadarajan-tw varadarajan-tw marked this pull request as ready for review June 25, 2024 11:11
@varadarajan-tw varadarajan-tw changed the title [Release Scripts] Improvements to release scripts [Release Scripts] Improvements Jun 25, 2024
@varadarajan-tw varadarajan-tw changed the title [Release Scripts] Improvements [Release Scripts] Fix changelog formatting and bump checkout/setup-node github action versions Jun 25, 2024
@varadarajan-tw varadarajan-tw merged commit eca12ae into main Jun 25, 2024
11 checks passed
@varadarajan-tw varadarajan-tw deleted the fix-changelog-parser branch June 25, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants