-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSENT-309: Ensure consent data is copied for Segment Connections + Profiles #2070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @chenxzhang thanks for raising this PR.
Here's some feedback and questions.
-
I can't see why the yarn.lock file was edited. Was this a mistake? If so can you please rectify?
-
Is your intent to grab andinclude the entrire object from the context.consent location? If so that's all good. Is there a partticular schema that this data should look like? Should we validate it in any way? If so, I can show you how to do this.
-
Could you please attach evidence of testing howing what the context.consent object looks like please?
Thanks for the review!
|
Thanks @chenxzhang . I still think the yarn.lock file shouldn't change. Any chance you could rebase from main? it might fix that issue. |
…on-destinations into CONSENT-309/segment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Left few minor comments.
description: 'Segment event consent category preferences.', | ||
type: 'object', | ||
default: { '@path': '$.context.consent' }, | ||
additionalProperties: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think addtionalProperties
is necessary here would help considering the field is hidden.
description: 'Segment event consent category preferences.', | ||
type: 'object', | ||
default: { '@path': '$.context.consent' }, | ||
additionalProperties: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above. additionalProperties
are not required for this use case.
@@ -7,3 +7,7 @@ export const MissingUserOrAnonymousIdThrowableError = new PayloadValidationError | |||
export const InvalidEndpointSelectedThrowableError = new PayloadValidationError( | |||
'A valid endpoint must be selected. Please check your Segment settings.' | |||
) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this error being used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleting it
Joe is out of office and the team needs this PR shipped. So, I am approving on behalf of Joe
hi @varadarajan-tw has this been deployed? |
While working on consent in RETL, we realized that the event's
context.consent.categoryPreferences
data isn't copied over. This PR adds the data to the track events for Segment Connections + Profiles.Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Tested the change in stage and verified the events in Segment Connections + Profiles have the consent data.
Segment Connections:
![Screenshot 2024-06-10 at 5 03 12 PM](https://private-user-images.githubusercontent.com/44650496/338345810-93394e27-5dea-4d85-b50a-5634201dbe7b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjczOTEsIm5iZiI6MTcyMTYyNzA5MSwicGF0aCI6Ii80NDY1MDQ5Ni8zMzgzNDU4MTAtOTMzOTRlMjctNWRlYS00ZDg1LWI1MGEtNTYzNDIwMWRiZTdiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA1NDQ1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFlN2ZjZWJlZWI1YjM5ZDQzNWNiNjIyYmNiNDQ5NjRjMDI2Mjc0MmRhMzEzM2EyYjMwODUwYWNlNWRjYTVmMDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.h9m4eapEdqcjhh8gYM_SkYwLCWkTQSViiGmGCzFRuOY)
![Screenshot 2024-06-10 at 5 03 49 PM](https://private-user-images.githubusercontent.com/44650496/338346002-d3fd5b65-b7aa-426a-b77e-49c62e345f94.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjczOTEsIm5iZiI6MTcyMTYyNzA5MSwicGF0aCI6Ii80NDY1MDQ5Ni8zMzgzNDYwMDItZDNmZDViNjUtYjdhYS00MjZhLWI3N2UtNDljNjJlMzQ1Zjk0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDA1NDQ1MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJiYzRkZTA3YmRhZTdiNzE5ZGUwYzIwMGVjYTk4MWI1YWQ5M2I5ZDdkYzJlNjRkZmRmNmY1YTE1MzJmM2Q3ZWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.28IP-1cDVe5IWbMXIPxSm57slJSDjjyV04mPLPCLtG8)
Segment Profiles: