GA4 - Cloud - Enabling button to add additional item params to product arrays #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varadarajan-tw
previously approved these changes
Jun 13, 2024
marinhero
approved these changes
Jun 13, 2024
|
hi @Kal-Segment I believe that this PR has been deployed. @varadarajan-tw can you confirm please? |
|
Yes. This PR has been deployed. |
|
Ah fantastic! Thanks a million team :D
I'll let the customer know!
*Kal Kola Cahill*
Solutions Architect
<http://segment.com/>
Docs <https://segment.com/docs/> · Blog
<https://segment.com/blog?utm_source=signature&utm_medium=email>
…On Thu, Jun 20, 2024 at 10:57 AM Varadarajan V ***@***.***> wrote:
Yes. This PR has been deployed.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/segmentio/action-destinations/pull/2088*issuecomment-2180285210__;Iw!!NCc8flgU!Zck9UyArsYcN5FQ3K_YQyamNCUqbAfjupc5AVqP8F1SeWxFJObbQ7OIwfR7Sf6gdLuoZrZ79ielUqdfDKmMYd8ndz_SUdw$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AU32LKEYQVZGOP7OTHXDVY3ZIKRQZAVCNFSM6AAAAABJD3PT6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBQGI4DKMRRGA__;!!NCc8flgU!Zck9UyArsYcN5FQ3K_YQyamNCUqbAfjupc5AVqP8F1SeWxFJObbQ7OIwfR7Sf6gdLuoZrZ79ielUqdfDKmMYd8llozHXgQ$>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kal-Segment is working with customers who pointed out that the GA4 Cloud Mode Destination doesn't allow customers to add custom item params to the products array. However the GA4 Web Mode Destination does.
This is a simple change to enable this in the UI for GA4 Cloud Mode.
Here and here are the GA4 API docs which state that custom item params can be added.
Here's where the GA4 Web Mode Destination enables this capability (via a single line).
Kal would simply like to enable the same thing for Cloud Mode. Could someone who looks after this Destination please review + approve?
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.