Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRATCONN-3874]: Allowing Pinterest Actions to add additional fields #2108

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

itsarijitray
Copy link
Contributor

@itsarijitray itsarijitray commented Jun 24, 2024

Summary

Jira Ticket: https://segment.atlassian.net/browse/STRATCONN-3874

Pinterest Conversion API doesn’t support fields outside their schema but click_id and partner_id fields are optional fields that are already supported by the API. We can add the mapping from segment side. Add Mapping Field functionality will not be required.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

Stage Test

Screenshot 2024-06-26 at 7 10 54 PM Screenshot 2024-06-26 at 7 11 57 PM

@itsarijitray itsarijitray requested a review from a team as a code owner June 24, 2024 16:14
@itsarijitray itsarijitray marked this pull request as draft June 24, 2024 16:14
@itsarijitray itsarijitray marked this pull request as ready for review June 25, 2024 09:17
@itsarijitray itsarijitray changed the title [STRATCONN-3874]: Pinterest Actions not allowing to add additional fields [STRATCONN-3874]: Allowing Pinterest Actions to add additional fields Jun 25, 2024
@itsarijitray itsarijitray marked this pull request as draft June 25, 2024 16:17
@itsarijitray itsarijitray marked this pull request as ready for review June 26, 2024 13:42
@joe-ayoub-segment joe-ayoub-segment merged commit 2fd9a5c into main Jun 27, 2024
11 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the bug/STRATCONN-3874 branch June 27, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants