channels-1094-canary #2120
channels-1094-canary #2120
Conversation
action-destination project is easier.
| echo "Publishing canary release for branch: \"$branch\"." | ||
| npx lerna publish --canary --preid "$branch" --include-merged-tags |
There was a problem hiding this comment.
The PR looks good. I am thinking about brining some package naming consistency between deploy-cloud-stage command and this one. We publish just core and destination-actions there to avoid publishing all the browser destinations while deploying to stage. The tag used there is next instead of canary and the preid includes short sha.
Do you think adding short sha to preid would be good idea? In the past, we have had trouble in getting lerna to publish again after a change.
There was a problem hiding this comment.
I'm not sure about the answer to either of these questions. The canary tag was pulled from some documentation I saw about deploying and testing changes in action-destinations.
Canary means that the release is not production ready right? Would next have the same value? What if someone else needed to use the next tag as well? As far as short SHA I'm open to change the script however you'd like.
There was a problem hiding this comment.
As long as this works, its fine. Highly recommend using the new deploy-cloud-stage docs of actions-cli and would appreciate feedback on it.
| echo "Publishing canary release for branch: \"$branch\"." | ||
| npx lerna publish --canary --preid "$branch" --include-merged-tags |
There was a problem hiding this comment.
As long as this works, its fine. Highly recommend using the new deploy-cloud-stage docs of actions-cli and would appreciate feedback on it.
|
hi @cogwizzle PR deployed |
feat: Creating a canary script so that publishing canary versions of the action-destination project is easier. I also sorted the scripts alphabetically so it is easier to parse them.
Testing
No testing required. This script added is purely to help during the development process.