Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date objects are removed from event properties #94

Closed
hadrien opened this issue May 8, 2017 · 2 comments
Closed

Date objects are removed from event properties #94

hadrien opened this issue May 8, 2017 · 2 comments

Comments

@hadrien
Copy link
Contributor

hadrien commented May 8, 2017

>>> from datetime import date
>>> from analytics import utils
>>> simple = {'birthdate': date(1981, 2, 2)}
>>> utils.clean(simple)
Dictionary values must be serializeable to JSON "birthdate" value 1981-02-02 of type <class 'datetime.date'> is unsupported.
{}

It should not be removed as json serializer permits date object.

hadrien added a commit to hadrien/analytics-python that referenced this issue May 8, 2017
@hadrien hadrien changed the title Date object are removed from event properties Date objects are removed from event properties May 8, 2017
hadrien added a commit to hadrien/analytics-python that referenced this issue May 8, 2017
@m-sanders
Copy link

Are there any plans to get this merged and release a new version anytime soon?

@hadrien
Copy link
Contributor Author

hadrien commented Sep 19, 2017

Hi @f2prateek, any chance to have this merged and released? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants