Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Client code - supports lists in properties/traits #14

Merged
merged 2 commits into from
Jun 25, 2013
Merged

Refactored Client code - supports lists in properties/traits #14

merged 2 commits into from
Jun 25, 2013

Conversation

dfee
Copy link
Contributor

@dfee dfee commented May 28, 2013

I PEP 8'd the client code, and also pointed out where future improvements ought to be made.

Also, Client now supports lists. This is important if you're trying to upload something like a shopping cart.

@ivolo ivolo merged commit 5770fd0 into segmentio:master Jun 25, 2013
@ivolo
Copy link
Contributor

ivolo commented Jun 25, 2013

Thanks!

ivolo pushed a commit that referenced this pull request Jun 25, 2013
fixing #14, fixing #12, adding change log and bumping version to 0.4.2
181cc10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dfee @ivolo