-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add online flush policy #863
Open
zikaari
wants to merge
1
commit into
master
Choose a base branch
from
flush_when_online
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
packages/core/src/flushPolicies/__tests__/online-flush-policy.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import type { | ||
| NetInfoChangeHandler, | ||
| NetInfoState, | ||
| } from '@react-native-community/netinfo'; | ||
| import { OnlineFlushPolicy } from '../online-flush-policy'; | ||
|
|
||
| let netInfoListener: NetInfoChangeHandler; | ||
| jest.mock('@react-native-community/netinfo', () => ({ | ||
| addEventListener: (cb: NetInfoChangeHandler) => { | ||
| netInfoListener = cb; | ||
| }, | ||
| })); | ||
|
|
||
| describe('OnlineFlushPolicy', () => { | ||
| it('triggers a flush when device (re-)connects to network', () => { | ||
| const policy = new OnlineFlushPolicy(); | ||
|
|
||
| policy.start(); | ||
|
|
||
| const observer = jest.fn(); | ||
|
|
||
| policy.shouldFlush.onChange(observer); | ||
|
|
||
| policy.onEvent(); | ||
| policy.onEvent(); | ||
| policy.onEvent(); | ||
|
|
||
| expect(observer).not.toHaveBeenCalled(); | ||
|
|
||
| // lets signal that the device is now connected | ||
| netInfoListener({ isConnected: true } as NetInfoState); | ||
|
|
||
| expect(observer).toHaveBeenCalledWith(true); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import NetInfo, { NetInfoState } from '@react-native-community/netinfo'; | ||
| import { FlushPolicyBase } from './types'; | ||
|
|
||
| /** | ||
| * OnlineFlushPolicy uploads events when the device (re-)connects to network | ||
| */ | ||
| export class OnlineFlushPolicy extends FlushPolicyBase { | ||
| private unsubscribe: (() => void) | undefined; | ||
|
|
||
| start(): void { | ||
| this.unsubscribe = NetInfo.addEventListener((state) => { | ||
| if (state.isConnected === true) { | ||
| this.shouldFlush.value = true; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| end(): void { | ||
| this.unsubscribe?.(); | ||
| } | ||
|
|
||
| onEvent(): void { | ||
| // not applicable | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a native module can you add to the
readmethat they have to manually install this dependency?In RN Native dependencies are not autolinked (only the NPM package is installed)