page/screen: allow no name

segmentio · Sep 10, 2015 · ce95502 · ce95502
1 parent 8ca2101
commit ce95502
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/lib/segment/analytics/client.rb b/lib/segment/analytics/client.rb
@@ -254,7 +254,6 @@ def screen(attrs)
         timestamp = attrs[:timestamp] || Time.new
         context = attrs[:context] || {}
 
-        fail ArgumentError, '.name must be a string' if name.empty?
         fail ArgumentError, '.properties must be a hash' unless properties.is_a? Hash
         isoify_dates! properties
 

diff --git a/spec/segment/analytics/client_spec.rb b/spec/segment/analytics/client_spec.rb
@@ -223,10 +223,6 @@ class Analytics
           expect { @client.screen :name => 'foo' }.to raise_error(ArgumentError)
         end
 
-        it 'should error without name' do
-          expect { A@client.screen :user_id => 1 }.to raise_error(ArgumentError)
-        end
-
         it 'should not error with the required options' do
           @client.screen Queued::SCREEN
         end

diff --git a/spec/segment/analytics_spec.rb b/spec/segment/analytics_spec.rb
@@ -67,10 +67,6 @@ class Analytics
           expect { analytics.page :name => 'foo' }.to raise_error(ArgumentError)
         end
 
-        it 'should error without name' do
-          expect { analytics.page :user_id => 1 }.to raise_error(ArgumentError)
-        end
-
         it 'should not error with the required options' do
           analytics.page Queued::PAGE
           sleep(1)
@@ -85,11 +81,6 @@ class Analytics
         it 'should error without name' do
           expect { analytics.screen :user_id => 1 }.to raise_error(ArgumentError)
         end
-
-        it 'should not error with the required options' do
-          analytics.screen Queued::SCREEN
-          sleep(1)
-        end
       end
 
       describe '#flush' do