Faraday dependency causing issues

[jtippett]

Hi,

the dependency on Faraday is declared in such a way that it is causing problems:

spec.add_dependency 'faraday', ['>= 0.8', '< 0.10']

Faraday is now on 0.9 but users of analytics-ruby cannot update as it conflicts with this requirement. IMO unless there is a specific known incompatibility with 0.10 (impossible, since it is not released yet), it's inappropriate to exclude it in this way. '>= 0.8' should be sufficient.

[calvinfo]

huh, yeah, we can certainly relax it!

[mikeatlas]

+1

[mikeatlas]

Any update on this? I can't update my bundle right now in a straightforward manner without this breaking dependency issue.

[calvinfo]

Yep, just relaxed from the latest version!

[mikeatlas]

Bundler could not find compatible versions for gem "faraday":
In Gemfile:
analytics-ruby (= 0.6.0) ruby depends on
faraday (< 0.9, >= 0.7.4) ruby

analytics-ruby (= 0.6.0) ruby depends on
  faraday (0.9.0)

[seanmcoleman]

Also having the same problem as @mikeatlas

[mikeatlas]

Might need to open a new ticket...

On Feb 28, 2014, at 12:51 AM, Sean Coleman notifications@github.com wrote:

Also having the same problem as @mikeatlas

—
Reply to this email directly or view it on GitHub.

[calvinfo]

hey guys, yeah the problem seems to be that faraday_middleware actually requires < 0.9 which is where the conflict is coming from. there's some progress on it: lostisland/faraday_middleware#74

it's probably worth dropping all of these deps and just going with core libraries, since we're not doing anything fancy. making json requests shouldn't be too difficult

[pickerflicker]

The current gemspec won't work in bundler for this reason:

Bundler could not find compatible versions for gem "faraday":
In Gemfile:
analytics-ruby (~> 0.6.0) ruby depends on
faraday (< 0.9, >= 0.7.4) ruby

analytics-ruby (~> 0.6.0) ruby depends on
  faraday (0.9.0)

[calvinfo]

yeah, that's thanks to faraday_middleware I believe. planning on taking a look at this tonight and switching to the core libs

[jemgold]

:( did you get a chance to take a look at this? Somehow our production app has dropped back to analytics-ruby 0.0.1 and I can't get any recent version running because lots of other gems now depend on faraday 0.9

¯_(ツ)_/¯

[calvinfo]

@jongd yep, just removed faraday with 1.0.0. if you give it a spin, please let me know if you run into any problems!

[jemgold]

Hero, thanks so much.

[mikeatlas]

working for me now. thanks