This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Move tests to typescript #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmikaelian
commented
Aug 27, 2020
| @@ -68,6 +68,7 @@ describe('map', function() { | |||
|
|
|||
| it('should ignore enumerable properties on arrays', function() { | |||
| var array = ['a', 'b', 'c']; | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
I actually have no idea what this test is trying to accomplish. I've never seen dot notation syntax on an array like this.
bryanmikaelian
force-pushed
the
bryan/ts-tests
branch
29 times, most recently
from
3763adf
to
332ab43
Compare
bryanmikaelian
force-pushed
the
bryan/ts-tests
branch
2 times, most recently
from
bb6a04d
to
665627e
Compare
bryanmikaelian
force-pushed
the
bryan/ts-tests
branch
from
665627e
to
6d0e2a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
===========================================
+ Coverage 96.29% 100.00% +3.70%
===========================================
Files 3 1 -2
Lines 54 3 -51
===========================================
- Hits 52 3 -49
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
bryanmikaelian
requested review from
a team
and removed request for
nettofarah and
pooyaj
dk1027
approved these changes
Sep 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates all tests to Typescript
Note: Due to the need to support IE9+, we are specifically pinning
bufferandassertto versions that support IE9.buffer^5does not work in IEassert^2only supports IE11+Test plan
Testing not required because this is a dev only change
Release plan
New version is not required because it's a dev only change
Checklist