Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay custom customer traits to Friendbuy destination #504

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dondi
Copy link

@dondi dondi commented Aug 24, 2020

What does this PR do?

This PR allows users of the Friendbuy destination to relay customized customer properties to Friendbuy, beyond the standard set that is currently accepted.

Are there breaking changes in this PR?

No.

Any background context you want to provide?

Friendbuy allows its merchants to add custom traits to their customers when integrating directly with the Friendbuy customer tracking API as part of a feature called widget targeting: http://help.friendbuy.com/en/articles/1916126-widget-targeting

We would like to allow our merchants to pass these custom parameters through the identify event to Friendbuy's Destination integration, so that they can use this feature via Segment. The Friendbuy Segment integration currently only accepts Customer ID, Email Address, First Name, and Last Name. We'd like to be able to allow merchants to pass in custom parameters through the identify event, such as age, VIP, etc.

Is there parity with the server-side/android/iOS integration components (if applicable)?

n/a

Does this require a new integration setting? If so, please explain how the new setting works

No.

Links to helpful docs and other external resources

General customer tracking API: https://developers.friendbuy.com/#tracking

Widget targeting feature: http://help.friendbuy.com/en/articles/1916126-widget-targeting

@@ -1,3 +1,9 @@
1.0.8 / 2020-08-24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a minor feature. Can we make this 1.1.0?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, go ahead 👍

@@ -1,3 +1,9 @@
1.1.0 / 2020-12-11
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mericsson apologies—I belatedly realized that I should be the one to change the version 😅 I have now modified it along with the date. Let me know if any further issues arise. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants