qsort: add benchmarks from the standard library #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will let us be more confident that a custom sort algorithm makes
sense to use, especially when e.g. the Go standard library introduces
a new sorting algorithm, we can compare the two.
On my Mac, using the pdqsort from Go 1.19, the relevant timings are:
Sort8/100000-10 4.91ms ± 0%
Sort8/1000000-10 60.1ms ± 0%
StdlibSort8/100000-10 8.16ms ± 0%
StdlibSort8/1000000-10 103ms ± 0%
Sort8/100000-10 163MB/s ± 0%
Sort8/1000000-10 133MB/s ± 0%
StdlibSort8/100000-10 98.0MB/s ± 0%
StdlibSort8/1000000-10 77.5MB/s ± 0%
Compared to the Go 1.18 sort algorithm:
Sort8/100000-10 4.90ms ± 0%
Sort8/1000000-10 59.0ms ± 0%
StdlibSort8/100000-10 8.53ms ± 0%
StdlibSort8/1000000-10 105ms ± 0%
Sort8/100000-10 163MB/s ± 0%
Sort8/1000000-10 136MB/s ± 0%
StdlibSort8/100000-10 93.8MB/s ± 0%
StdlibSort8/1000000-10 76.0MB/s ± 0%
So the Go standard library sort performance is improving but we are
still about 40% faster than the benchmark.
kevinburkesegment
force-pushed
the
sort-benchmark
branch
3 times, most recently
from
bc0e2c1
to
f884d76
Compare
|
For completeness, adding a snapshot for a run on a x86: |
achille-roussel
approved these changes
Apr 26, 2022
kevinburkesegment
force-pushed
the
sort-benchmark
branch
2 times, most recently
from
38cab90
to
a2379cd
Compare
kevinburkesegment
force-pushed
the
sort-benchmark
branch
from
a2379cd
to
0eb1ec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will let us be more confident that the qsort makes sense to use,
especially when e.g. the Go standard library introduces a new sorting
algorithm, we can compare the two.
On my Mac, using the pdqsort from Go 1.19, the relevant timings are:
Compared to the Go 1.18 sort algorithm:
So the Go standard library sort performance is improving but we are
still about 40% faster than the benchmark.