Add support for darwin/arm64 (Apple Silicon M1)

[chrisgoffinet]

No description provided.

[sindhusegment]

Hey @chrisgoffinet so this PR is very similar to another one merged recently: #307

For this, if you wish to generate a new github release and also have a release to packagecloud, you would want to include publish-github-darwin-arm64 on

chamber/Makefile.release

Line 33 in 235234a

publish-github: publish-github-darwin publish-github-linux publish-github-windows publish-github-deb publish-github-rpm publish-github-sha256sums

and

chamber/Makefile.release

Line 35 in 235234a

publish-packagecloud: publish-packagecloud-deb publish-packagecloud-rpm

[chrisgoffinet]

Hey @chrisgoffinet so this PR is very similar to another one merged recently: #307

For this, if you wish to generate a new github release and also have a release to packagecloud, you would want to include publish-github-darwin-arm64 on

chamber/Makefile.release

Line 33 in 235234a

publish-github: publish-github-darwin publish-github-linux publish-github-windows publish-github-deb publish-github-rpm publish-github-sha256sums

and

chamber/Makefile.release

Line 35 in 235234a

publish-packagecloud: publish-packagecloud-deb publish-packagecloud-rpm

Thanks. I was just following the convention from prior commit. Might be a bug we don't push the linux-arm64, as thats how I missed that. I pushed up a change to include darwin-arm64 on github now.

[sindhusegment]

Yeah it is a bug - I've just created a PR for it: #311
Not sure what the procedure is to get your PR approved but we're looking into it

[chrisgoffinet]

@sindhusegment does this look good now?

[sindhusegment]

@sindhusegment does this look good now?

Hey @chrisgoffinet sorry for the delayed response on this. So we've actually got a linux-arm64 PR that we merged recently but we're having issues generating an arm64 release in CircleCI for both a github binary and a packagecloud debian release. Were you able to test to see if you can successfully build the package and release it? If you have, then this would be super helpful for us and it will move along both your release for darwin-arm64 and ours for linux-arm64

[eddeee888]

Hi @sindhusegment @chrisgoffinet , how are we going with this PR? What's needed to push this over the line? :)

[asaf-erlich]

Hello @eddeee888 , unfortunately getting chamber to successfully build for arm64 did not get finished during @sindhusegment 's internship here. It is still on our team's roadmap for this year but I don't know 100% for sure which quarter that will get prioritized.

In the meantime if whoever owns this PR can just make sure to test a local build for darwin arm64 I'm happy to get this approved and merged. Potentially in that case if comments in the code can mention that it would be nice. We can worry about automatic building and uploading to packagecloud at a later time. This way at minimum people can be unblocked if they need it.

[asaf-erlich]

cc @emmy-byrne-segment so you're aware of this PR as well ^^

[emmy-byrne-segment]

This all seems correct to me. Doing some local checks before we merge.

[emmy-byrne-segment]

Tested with a rudimentary test on an M1 machine and build output is functional and correct arch.

[eddeee888]

Thank you so much! Does this mean the next release should have the arm64 version? If so, when would that be if you don't mind me asking?
In the meantime, if I need to use a specific binary, would the recommendation be to check this out and build the binaries locally? :)