Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --retries/-r root flag and configure the SSM client to retry #36

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

toshok
Copy link
Contributor

@toshok toshok commented Oct 10, 2017

we at honeycomb are running up against aws throttling DescribeParameter api calls (issue #34)

This diff adds a flag for max-retries (--retries/-r). The default value is 10, which seems to fix things for 15 simultaneous runs of while :; do chamber exec dev -- echo hi ; echo bye; done.

The flag is attached to the RootCmd, so invoking it will look something like:

$ chamber --retries 100 exec something -- command
$ chamber -r 100 exec something -- command

numRetries is passed to all store.NewSSMStore calls, which doesn't feel very golang-like. Maybe I should add a store.StoreConfig struct? Let me know!

@dfuentes
Copy link
Contributor

Looks great, thanks for the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants