chore: Convert to log/slog #519
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The small amount of verbose logging in the exec command has been converted to debug logging under log/slog. Accordingly, the `--verbose` command line flag has been deprecated in favor of the more flexible `--log-level` flag.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
==========================================
- Coverage 36.01% 35.90% -0.11%
==========================================
Files 29 29
Lines 2546 2562 +16
==========================================
+ Hits 917 920 +3
- Misses 1550 1563 +13
Partials 79 79 ☔ View full report in Codecov by Sentry. |
|
slog was introduced in Go 1.21, so this cannot be integrated yet since chamber still supports go 1.20. I'll leave this PR inactive until the 1.23 release, which is expected in August (about 2 months from now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small amount of verbose logging in the exec command has been
converted to debug logging under log/slog. Accordingly, the
--verbosecommand line flag has been deprecated in favor of the more flexible
--log-levelflag.