This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Listening to non-react updates to the preferences and update the react component #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooyaj
requested review from
nettofarah,
juliofarah,
williamgrosset,
danieljackins and
dk1027
juliofarah
approved these changes
Nov 13, 2020
nettofarah
approved these changes
Nov 15, 2020
pooyaj
force-pushed
the
pj/LIBWEB-482
branch
from
ab1e30a
to
7b015df
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Looks like users can use
savePreferencesto update the preferences in the cookie, but that does not update the internal state of our consent manager react component.Solution: Re-hydrate the state ( by calling reset ) when the dialog opens.
Ref: https://segment.atlassian.net/browse/LIBWEB-482