Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Bool method comment #115

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Fixes Bool method comment #115

merged 2 commits into from
Dec 11, 2021

Conversation

Succo
Copy link
Contributor

@Succo Succo commented Dec 11, 2021

It seems the comment was a wrong copy paste of the string method.

Not sure about "returns a byte slice" but it seems to be used on all other similar methods.

json/token.go Outdated Show resolved Hide resolved
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@achille-roussel achille-roussel merged commit 4e2cc2a into segmentio:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants