thrift: allow reusing struct fields #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to allow reusing inner pointer fields of struct values in the thrift decoder. The existing implementation would always zero out the struct value before decoding it, which means pointers are set to
nil
and whatever object they were referencing is lost.Most applications won't need this optimization and can allocate new objects to decode values into (they will have the zero value then). Applications that do need this optimization are aware that they must zero-out the objects they reuse across decoding operations, which makes it a meaningful change.