Adds no-redeclare to our rules #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we deployed the app, a bug I introduced in segmentio/app#e3fa8a1886cb17e8a3765d70c215b42591729c0d prevented the page from loading for all users. We needed to rollback, and I introduced a fix segmentio/app#7fb59a0602d55d8095c249d583fab6ddd75a975d that has fixed the issue. The problem was that I accidentally created a conflicting variable in the global scope for that module. (`var` up top, `function` way later) By adding `no-redeclare`, this will catch that same problem in the future. As noted in eslint/eslint#2953, this has already been fixed in `master`, so now we just await a new release. In the meantime, adding this rule will still be a good idea as it will catch other similar problems.
|
haha one of the many reasons I dislike hoisting and function declarations, makes this kind of error so easy 😿 |
ndhoule
pushed a commit
that referenced
this pull request
Jul 9, 2015
Adds no-redeclare to our rules
|
Published to npm in https://github.com/segmentio/eslint-config/releases/tag/1.0.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we deployed the app, a bug I introduced in segmentio/app@e3fa8a1886cb17e8a3765d70c215b42591729c0d prevented the page from loading for all users. We needed to rollback, and I introduced a fix segmentio/app@7fb59a0602d55d8095c249d583fab6ddd75a975d that has fixed the issue.
The problem was that I accidentally created a conflicting variable in the global scope for that module. (
varup top,functionway later) By addingno-redeclare, this will catch that same problem in the future. As noted in eslint/eslint#2953, this has already been fixed inmaster, so now we just await a new release. In the meantime, adding this rule will still be a good idea as it will catch other similar problems.