Omit children, items, and onChange from Combobox.autocompleteProps (#…

…1526)
segmentio · Oct 25, 2022 · f16ca39 · f16ca39
1 parent 0e772df
commit f16ca39
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -1054,7 +1054,7 @@ export interface ComboboxOwnProps {
   /**
    * Properties forwarded to the autocomplete component. Use with caution.
    */
-  autocompleteProps?: AutocompleteProps
+  autocompleteProps?: Omit<AutocompleteProps, 'children' | 'items' | 'onChange'>
   /**
    * When true, open the autocomplete on focus.
    */

diff --git a/index.test-d.ts b/index.test-d.ts
@@ -1,5 +1,5 @@
 import { expectAssignable, expectType, expectError } from 'tsd'
-import { defaultTheme, mergeTheme, StyleProps, Intent, Theme, Fill, Partial, Pick, Color } from '.'
+import { defaultTheme, mergeTheme, StyleProps, Intent, Theme, Fill, Partial, Pick, Color, ComboboxProps } from '.'
 
 interface ThemeOverrides extends Partial<Pick<Theme, 'colors' | 'fills' | 'components'>> {
   colors: {
@@ -125,3 +125,7 @@ const themeWithTopLevelColorsArray = {
   colors: ['#0f4880', '#1d781d', '#db0a5b', '#8d6708', '#d43900']
 }
 expectError(mergeTheme(defaultTheme, themeWithTopLevelColorsArray))
+
+expectError<ComboboxProps>({ autocompleteProps: { children: 'error' } })
+expectError<ComboboxProps>({ autocompleteProps: { onChange: () => {} } })
+expectError<ComboboxProps>({ autocompleteProps: { items: [] } })