Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing intent value 'info' in Menu.Item prop types #1319

Closed
polosson opened this issue Sep 15, 2021 · 0 comments · Fixed by #1341
Closed

Missing intent value 'info' in Menu.Item prop types #1319

polosson opened this issue Sep 15, 2021 · 0 comments · Fixed by #1341

Comments

@polosson
Copy link

Using info as a value for the prop intent of a Menu.item works as expected, but displays a warning in the console, saying that the prop is invalid:

Warning: Failed prop type: Invalid prop `intent` of value `info` supplied to `ForwardRef(MenuItem)`, expected one of ["none","success","warning","danger"].

I think we just need to add this value to this line:

intent: PropTypes.oneOf(['none', 'success', 'warning', 'danger']),

Maybe it should use a global configuration array of allowed values for this prop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant