Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There are a couple issues having to do with the
intent
prop on various components:index.d.ts
and those defined viaPropTypes
) do not account for the fact that user-defined intents can be added via theming.intent
prop is inconsistent from one component to the next. See the table below.In an ideal world, these components would be consistent and the types could be generated based on what user-defined intents there are, if any. Doing that seems worthwhile, but that's going to be a bigger initiative. I think this will solve the problem for now.
Resolves #1319
Screenshots (if applicable)
Documentation