Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty divs in evergree-portal-container using Tooltip #1365

Closed
vojtatom opened this issue Nov 19, 2021 · 1 comment · Fixed by #1549
Closed

Empty divs in evergree-portal-container using Tooltip #1365

vojtatom opened this issue Nov 19, 2021 · 1 comment · Fixed by #1549

Comments

@vojtatom
Copy link

Hello, I think I have encountered similar issue to this one #329 using the Tooltip component.

I'm using version 6.6.1

React:

<Tooltip content="Layers" >
    <IconButton icon={LayersIcon} appearance="minimal" onClick={() => toggleMenu(Menu.Layers)} />
</Tooltip>

Looks like tooltip creates one extra div on hover, see:
Before hover:

before

On hover:

hover

After mouse leave:

after

I suppose #330 did not fix the problem or am I missing something?
Thank you for such a great library guys. 😊
@brandongregoryscott brandongregoryscott mentioned this issue Nov 21, 2022
Merged
3 tasks
brandongregoryscott added a commit that referenced this issue Nov 21, 2022
@brandongregoryscott
Convert Portal to functional component, properly remove DOM element o…
162b332 
…n unmount (#1549)

Resolves #1365
@brandongregoryscott
Copy link
Contributor

This should be resolved v6.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert Portal to functional component, properly remove DOM element on unmount
2 participants
@brandongregoryscott @vojtatom