Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectMenu close on click #456

Closed
andrwh opened this issue Nov 25, 2018 · 3 comments
Closed

SelectMenu close on click #456

andrwh opened this issue Nov 25, 2018 · 3 comments

Comments

@andrwh
Copy link

andrwh commented Nov 25, 2018

Would love the ability to close the SelectMenu when an option is clicked
@stale
Copy link

stale bot commented Mar 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wont-fix label Mar 11, 2019
@robphoenix
Copy link
Contributor

Not stale. 😺
Would be good to hear any opinion from the maintainers, whether this is a possible consideration.

@stale stale bot removed the wont-fix label Jun 18, 2019
@mshwery mshwery added the pinned label Jun 18, 2019
@mshwery
Copy link
Contributor

mshwery commented Jun 18, 2019

Sounds like a good addition! If y'all want to take a stab at a PR to implement this, I would be happy to review. If not, we can add it to the docket.

// cc @solon-aguiar

@robphoenix robphoenix mentioned this issue Jun 19, 2019
Merged
robphoenix added a commit to robphoenix/evergreen that referenced this issue Jun 20, 2019
@robphoenix
Add closeOnSelect prop to SelectMenu
54c39cb 
This change adds a prop that when true the select
menu will close when an option has been selected.

closes segmentio#456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mshwery @robphoenix @andrwh