Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout inconsistency for removeable alert's X button #1210

Merged
merged 1 commit into from May 22, 2021
Merged

Fix layout inconsistency for removeable alert's X button #1210

merged 1 commit into from May 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 22, 2021

Overview
Fixes a layout inconsistency in the Alert component when the Alert is removable.

Screenshots (if applicable)
Screenshot

The right side represents the results of this PR. Black guide lines added for clarity.

Documentation
N/A

Copy link
Contributor

@akleiner2 akleiner2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice eye! Thanks for the PR

@akleiner2 akleiner2 merged commit 872eee8 into segmentio:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants