Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back icon search in the docs #1227

Merged
merged 3 commits into from Jun 9, 2021
Merged

Bring back icon search in the docs #1227

merged 3 commits into from Jun 9, 2021

Conversation

akleiner2
Copy link
Contributor

Overview
This PR brings back icon searching into the docs site so that users can quickly find what they're looking for.

Screenshots (if applicable)
image

Documentation

  • Updated Typescript types and/or component PropTypes
  • Added / modified component docs
  • Added / modified Storybook stories

@akleiner2 akleiner2 requested a review from kamebkj June 9, 2021 00:28
@netlify
Copy link

netlify bot commented Jun 9, 2021

✔️ Deploy Preview for evergreen-storybook ready!

🔨 Explore the source changes: 789a254

🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/60c0cf776e8baa000757d5dc

😎 Browse the preview: https://deploy-preview-1227--evergreen-storybook.netlify.app

Copy link
Contributor

@kamebkj kamebkj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we can add a "InfoSignIcon copied to clipboard" when clicking on the icon. Otherwise left one comment and the rest lgtm.

paddingY={majorScale(3)}
className={css({
':hover': {
opacity: 0.8,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not change the opacity and keep it 1 when hover. hover should not dim the target visually

@akleiner2 akleiner2 merged commit 95e9bfd into master Jun 9, 2021
@akleiner2 akleiner2 deleted the bring-back-icon-searh branch June 9, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants