Switch to new faker #1425
Closed
Switch to new faker #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run the CI tests so we can see if everything works |
|
Hey @Shinigami92 - thanks for your contribution! My apologies - I should've assigned that issue to myself, I pushed out a PR over the weekend to take care of it (#1421) - it looks like we needed to upgrade to node 14, too. The changes look pretty similar aside from the direct import of the |
|
Oh it's my fault that I didn't checked that there is already an issue / a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update faker dependency
Related to faker-js/faker#542
Screenshots (if applicable)
Documentation