Fix: allow OptionsList to not focus on the search bar #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for evergreen-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| /** | ||
| * When true, menu auto focuses on the search/filter bar. | ||
| */ | ||
| shouldAutoFocus: PropTypes.bool |
There was a problem hiding this comment.
Can we add this to the SelectMenuProps interface in index.d.ts as well? (Listing @default true might be helpful as well)
index.d.ts
Outdated
| @@ -2387,6 +2387,10 @@ export interface SelectMenuProps extends Omit<PopoverProps, 'position' | 'conten | |||
| * When true, show the filter. | |||
| */ | |||
| hasFilter?: boolean | |||
| /** | |||
| * @default true. When true, auto focuses on the search/filter bar. | |||
There was a problem hiding this comment.
Can we move the description on a separate line from the @default JSDoc attribute? I'm thinking that shows up weird in your IDE:
vs the expected:
There was a problem hiding this comment.
i see, thanks for the note!
brandongregoryscott
approved these changes
Oct 7, 2022
chenxzhang
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Jira ticket: https://segment.atlassian.net/browse/PROT-4257
Loom: https://www.loom.com/share/79fd27a5ac2a415c93aac856c50c427a
Overview
There's a bug in Protocols tracking plan, where the focus of the input changes to the focus of the filter search bar. This happens because the tracking plan editor pages refreshes every few seconds and the focus is autofocused to the search bar component. This PR adds a prop
shouldAutoFocustoOptionsListso that we can disable the autofocus as needed. The change will not affect existing behaviors.Screenshots (if applicable)
Documentation