Port codemods to TypeScript, add codemods for replacing Nudge and SidebarTab components #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n ImportSpecifierCollection, refactor to find by name + remove
✅ Deploy Preview for evergreen-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…ssing comment to replace-nudge, do not strip comments in distributed js
codemods/src/6.0.0-7.0.0/__testfixtures__/replace-nudge.output.js
Outdated
Show resolved
Hide resolved
dlasky
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR overhauls our
codemodsdirectory and adds two new codemods, one for removing SidebarTab components (replacing withTab direction="horizontal") and one for removing Nudge components (replacing withPulsarwhere possible).codemodsdirectory is now written in TypeScript and added to the build processjscodeshifthas been updatedjscodeshiftto help reduce duplicated code & improve readabilityThere are a decent amount of tests, but not all of the new utility functions are tested. We can continue to back-fill these as new codemods are added, in addition to the regular input/output transformation tests.
Also... I noticed we were bundling up
*.test.jsfiles the main package. Looks like the glob for thebuild-commonjsandbuild-esmscripts is not picking up all of the test files, so excluding them explicitly from thefilesarray in the package.json should tidy our distribution up a little!Screenshots (if applicable)
Documentation