Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated components: Nudge, SidebarTab and SegmentedControl #1560

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Remove deprecated components: Nudge, SidebarTab and SegmentedControl #1560

merged 3 commits into from
Dec 5, 2022

Conversation

brandongregoryscott
Copy link
Contributor

@brandongregoryscott brandongregoryscott commented Nov 29, 2022

Overview

This PR removes the following components:

  • Nudge (replaced with Pulsar)
  • SidebarTab (replaced with Tab with direction="vertical" prop)
  • SegmentedControl (replaced with Group and Button/Input components - up to the consumer to replace the onClick/isActive logic)

Screenshots (if applicable)

Documentation

  • Updated Typescript types and/or component PropTypes
  • Added / modified component docs
  • Added / modified Storybook stories

@netlify
Copy link

netlify bot commented Nov 29, 2022

Deploy Preview for evergreen-storybook ready!

Name Link
🔨 Latest commit 2d472fd
🔍 Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/63869ac195734b0008e01e8f
😎 Deploy Preview https://deploy-preview-1560--evergreen-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandongregoryscott brandongregoryscott changed the base branch from master to v7 November 30, 2022 00:17
@brandongregoryscott brandongregoryscott merged commit a2ce1a3 into segmentio:v7 Dec 5, 2022
@brandongregoryscott brandongregoryscott deleted the remove-deprecated-components branch December 5, 2022 16:30
@brandongregoryscott brandongregoryscott added this to the v7 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants