Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ogg supported mime type #1651

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

camielvs
Copy link
Contributor

Overview
Hey!
Really super quick PR to add the .ogg audio file format as a supported mime type for the File Uploader component.

I am currently using the File Uploader exclusively for .ogg files. It runs into problems when removing a file from the FileCard list because rebaseFiles tries to verify the remaining files against your list of supported mime types.

In future you could consider splitting this out into .oga (audio), .ogv (video) and .ogx (application) mime-types, but for now it's probably fine to use the more general .ogg for just audio.

Thanks!

Screenshots (if applicable)

Documentation

  • Updated Typescript types and/or component PropTypes
  • Added / modified component docs
  • Added / modified Storybook stories

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for evergreen-storybook ready!

Name Link
🔨 Latest commit bb8d901
🔍 Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/64934891086bc00008450a5f
😎 Deploy Preview https://deploy-preview-1651--evergreen-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@brandongregoryscott
Copy link
Contributor

Thanks @camielvs!

@brandongregoryscott brandongregoryscott merged commit a01d147 into segmentio:master Jun 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants