Remove arrowKeysOverrides prop warning and improve editable cell scrolling in virtual table #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rowno
added a commit
that referenced
this pull request
Dec 18, 2018
* master: (49 commits) v4.8.0 Add scroll props to Table.VirtualBody (#461) 4.7.1 Fix manual control over <Popover> visibility (#448) 4.7.0 Add emptyView to <SelectMenu> (#445) remove old readmes (#444) 4.6.0 Fix Popover spills out of viewport (#432) Dialog: Add "contentContainerProps" (#441) closes #433. specify type "button" for filepicker button (#442) Remove arrowKeysOverrides prop warning and improve editable cell scrolling in virtual table (#443) 4.5.0 add arrow keys overrides (#439) 4.4.0 Add disabled tabs support (#395) Sketch file for designers (#430) Show runtime warnings only once (#422) 4.3.0 Runtime warnings (#415) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table.Cell
arrowKeysOverridesprop warningfalsefor aarrowKeysOverrideskey cancels any default interactione.preventDefaulton arrow key interaction to prevent scrolling in scrollable/virtual tables (hurting performance)