Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jumping check icon within <Switch> when placed inside <Dialog> #650

Merged
merged 1 commit into from Oct 23, 2019
Merged

Fix jumping check icon within <Switch> when placed inside <Dialog> #650

merged 1 commit into from Oct 23, 2019

Conversation

vadimdemedes
Copy link
Contributor

I still don't know what specifically caused it within <Dialog>, but the fix was to move scale transition onto svg itself.

Before:

Kapture 2019-10-23 at 15 19 53

After:

Kapture 2019-10-23 at 16 02 32

@vadimdemedes vadimdemedes changed the title Fix jumping check icon within <Switch> when placed inside <Dialog> Fix jumping check icon within <Switch> when placed inside <Dialog> Oct 23, 2019
@vadimdemedes vadimdemedes merged commit bb457e3 into master Oct 23, 2019
@vadimdemedes vadimdemedes deleted the cool-mad-max branch October 23, 2019 23:37
@dependabot-preview dependabot-preview bot mentioned this pull request Oct 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshwery mshwery mshwery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vadimdemedes @mshwery