Upgrade dev deps and fix linting errors #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rowno
reviewed
Jan 21, 2020
| @@ -165,12 +174,10 @@ | |||
| "lint-staged": { | |||
| "*.js": [ | |||
| "xo --fix", | |||
| "prettier --write", | |||
| "git add" | |||
| "prettier --write" | |||
There was a problem hiding this comment.
Won't removing the git add prevent the prettier changes from being committed?
There was a problem hiding this comment.
Nope! The latest version of lint-staged does that automatically be default. It actually told me to remove this line.
Rowno
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly small 馃槃 update that mostly focused on devDeps. I touched a few files to make the linter happy.