Allow header/footer to take close and update .d.ts #813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a follow-up to #746 which adds TypeScript definitions and expands the acceptable types for
header
andfooter
to include a function that accepts aclose
parameter, which allows custom headers and footers to close the Dialog.Screenshots (if applicable)
Confirmed locally with
yarn link
against an internal Segment service.Testing
Added / modified Storybook stories