Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rows get missing when multiple pages are fetched #12

Closed
nfssdq opened this issue Sep 20, 2018 · 1 comment
Closed

rows get missing when multiple pages are fetched #12

nfssdq opened this issue Sep 20, 2018 · 1 comment

Comments

@nfssdq
Copy link
Contributor

nfssdq commented Sep 20, 2018

Hi,

We recently tried to use your awesome project on Athena, but during testing we found some data is not returned. Upon investigating i found that whenever fetchNextPage is called, it skips the first row assuming it is a header, which is true for the first page only. The subsequent pages don't have this, so the first row gets missed. I hope you guys can take a look into this matter.

@tejasmanohar
Copy link
Contributor

tejasmanohar commented Sep 20, 2018

Nice find!

Could you send a PR with the fix and a test that has multiple pages, @nfssdq? There's another bug in this section of the code, too (see #10), if you'd like to tackle it at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants