Support arrays #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicbarnes
requested changes
Jun 17, 2021
tableize.go
Outdated
| @@ -13,6 +15,7 @@ type Input struct { | |||
| // Optional | |||
| HintSize int | |||
| Substitutions map[string]string | |||
| StringifyArr bool | |||
There was a problem hiding this comment.
Weird to shorten "Array" to "Arr", but not "Stringify". Can we change this to StringifyArrays bool?
tableize.go
Outdated
| if stringifyArr { | ||
| valByteArr, err := json.Marshal(val) | ||
| if err != nil { | ||
| log.Printf("[Error] Unable to marshall value `%v` err: %v", val, err) |
There was a problem hiding this comment.
Can we change this log line to something like:
log.Printf("go-tableize: dropping array value %+v that could not be converted to string: %s\n", val, err)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option to support arrays while flattening map.
This was originally raised by failure reported in this ticket: https://segment.atlassian.net/browse/SRC-2564
The change is backward compatible. Only if explicitly setting
StringifyArr=true, then array will be stringifiedTesting
Added relevant unit tests
Deployment
Merge to master
Rollback procedure
Revert this PR from master