Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for consumer group #1022

Merged
merged 10 commits into from
Nov 8, 2022
Merged

Conversation

rhansen2
Copy link
Collaborator

@rhansen2 rhansen2 commented Nov 3, 2022

Moving the consumer group to the Client has introduced a number of bugs. This fixes a couple of them.

@rhansen2
Copy link
Collaborator Author

rhansen2 commented Nov 3, 2022

Potentially helps with some of #1021

Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@rhansen2 rhansen2 merged commit a5f270d into segmentio:main Nov 8, 2022
@rhansen2 rhansen2 deleted the join-group-meta-parsing branch November 8, 2022 16:12
rhansen2 added a commit that referenced this pull request Nov 9, 2022
rhansen2 added a commit to rhansen2/kafka-go that referenced this pull request Nov 9, 2022
rhansen2 added a commit that referenced this pull request Nov 9, 2022
* Revert "Fixes for consumer group (#1022)"

This reverts commit a5f270d.

* Revert "Refactor Consumer Group to use Client (#947)"

This reverts commit ee37c7f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants