Writer: ensure batching logic factors in message headers #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicbarnes
force-pushed
the
issue-1050-message-batching-headers
branch
from
e484d20
to
cb2a487
Compare
rhansen2
approved these changes
Jun 23, 2023
mostafa
added a commit
to mostafa/xk6-kafka
that referenced
this pull request
Sep 20, 2023
mostafa
added a commit
to mostafa/xk6-kafka
that referenced
this pull request
Sep 20, 2023
* Update Go, k6 and other dependencies * Update actions * Increase golangci-lint timeout * Clean up after the test * Update tests to compensate for the size of the header Issue: segmentio/kafka-go#1050 PR: segmentio/kafka-go#1132 Release: https://github.com/segmentio/kafka-go/releases/tag/v0.4.41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the decision to include a message in a batch does not consider headers, so you can get payloads that are larger than intended if you are close to your upper limit and then include headers. This adds a new test for batching with headers that failed and then a fix was added to correct the failing test. This also updates another test that began failing once we included the header length in this calculation.
This closes #1050