Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kafka.SeekDontCheck #295

Merged
merged 5 commits into from
Jun 21, 2019
Merged

add kafka.SeekDontCheck #295

merged 5 commits into from
Jun 21, 2019

Conversation

achille-roussel
Copy link
Contributor

This PR adds a flag that can be passed to the kafka.(*Conn).Seek method as an optimization to avoid making a metadata request when positioning the connection.

Copy link
Contributor

@stevevls stevevls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What do you think of adding a quick unit test?

@achille-roussel achille-roussel merged commit 0b38267 into master Jun 21, 2019
@achille-roussel achille-roussel deleted the seek-dont-check branch June 21, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants