Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance,typo: prealloc slice for performance and fix typo #816

Merged
merged 2 commits into from
Jan 21, 2022
Merged

performance,typo: prealloc slice for performance and fix typo #816

merged 2 commits into from
Jan 21, 2022

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Dec 30, 2021 •
edited
Loading

Prealloc the slice will make performance well.

And I think we can check it by https://github.com/alexkohler/prealloc or https://github.com/golangci/golangci-lint

@xiekeyi98 xiekeyi98 changed the title performance,typo: prealloc slice for performance and fix typoe. performance,typo: prealloc slice for performance and fix typo Dec 30, 2021
@achille-roussel achille-roussel self-assigned this Jan 21, 2022
achille-roussel
achille-roussel approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the improvements!

@achille-roussel achille-roussel merged commit d81d37a into segmentio:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

Assignees

@achille-roussel achille-roussel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiekeyi98 @achille-roussel