attempt to detect improper TLS config #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhansen2
commented
Feb 7, 2022
| var sizeBytes [4]byte | ||
| binary.BigEndian.PutUint32(sizeBytes[:], uint32(size)) | ||
| if looksLikeUnexpectedTLS(sizeBytes) { | ||
| err = fmt.Errorf("%w: broker appears to be expecting TLS", io.ErrUnexpectedEOF) |
There was a problem hiding this comment.
Not sure what the best way to phrase this message is.
when an io.ErrUnexpectedEOF is returned when reading a correlation ID, attempt to detect if the messages from the broker was a TLS Alert Message and decorate the returned error
rhansen2
force-pushed
the
detect-unexpected-tls
branch
from
a259dd9
to
47c588f
Compare
achille-roussel
approved these changes
Mar 4, 2022
Co-authored-by: Achille <achille.roussel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when an io.ErrUnexpectedEOF is returned when reading
a correlation ID, attempt to detect if the messages
from the broker was a TLS Alert Message and decorate
the returned error