Added file name data to collection items #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting the PR! Can this be achieved by using a second plugin (metalsmith-path or metalsmith-paths) after collections that adds the @dominicbarnes thoughts here? |
|
@lambtron thanks, using metalsmith-path seemed to work. Maybe we should document this somewhere in this project though? |
| @@ -5,6 +5,7 @@ var Matcher = require('minimatch').Minimatch; | |||
| var unique = require('uniq'); | |||
| var read = require('fs').readFileSync; | |||
| var loadMetadata = require('read-metadata').sync; | |||
| var path = require('path'); | |||
There was a problem hiding this comment.
This is superfluous, looks like it was added and left behind when not needed anymore.
|
Hey @dominicbarnes, good spot. I've rebased a couple of updates including a fix for the above:
|
Adds a `file` property to the collection item's data which contains the file name of the generated file. For example, this can be used in templates to create links. Includes test case.
lambtron
added a commit
that referenced
this pull request
Feb 16, 2016
Added file name data to collection items
|
@lambtron thanks, when do you think you'll release a new version of metalsmith-collections? |
|
This is causing conflicts with metalsmith-path and metalsmith-paths, see #62 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
fileproperty to the collection item's data which contains the file name of the generated file. For example, this can be used in templates to create links.Includes test case.