Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

When writing the diff file, Niffy does not wait for stream to close #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commits on Feb 2, 2018

  1. When writing the diff file, Niffy does not wait for the close of the …

    …stream.
    
    We encountered this issue while adding an upload to S3 to our after phase.
    The file uploaded to S3 contained partial data; indicating that there was two process competing to write and read the file.
    Fix is a simple on close handler.
    We also bumped the version of pngjs.
    
    note: potential bug/omission found in pngjs
    https://github.com/lukeapage/pngjs/blob/master/lib/png.js#L43
    Mathieu Simard committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    6158c1b View commit details
    Browse the repository at this point in the history