This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Fullpage screenshots #22

Closed

alanpilloud wants to merge 5 commits into segmentio:master from alanpilloud:master

alanpilloud commented Apr 4, 2018 •

edited

Which issue or problem is this solving?

How full page screen comparison is done #18 Fullpage screenshots

Remaining tasks

First merge PR When writing the diff file, Niffy does not wait for stream to close #20 , it is required for the fullpage diff to work properly

Request for comments

This is just something to get approved & merged
Of course any feedback will be considered

alanpilloud added 5 commits

April 4, 2018 07:31


          ignore vim swap files

fcafa0c


          capture fullpage screenshots

1302eb7


          wait for stream to close

3ece069


          fix body.scrolHeight calculation issue

560c9e7


          write tests in their own directory

2485ffc

This pull request was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.