Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more hashed parameters to list for Snapchat Conversions API (Actions) #5294

Conversation

sebashine-branly
Copy link

Proposed changes

This PR adds more parameters to the list of hashed parameters for Snapchat Conversions API (Actions).

Merge timing

Should only be merged after segmentio/action-destinations#1546 is merged, as it is responsible for adding these optional parameters.

Related issues (optional)

segmentio/action-destinations#1546

@sebashine-branly sebashine-branly changed the title docs: add mention of more hashed parameters Added more hashed parameters to list for Snapchat Conversions API (Actions) Sep 4, 2023
@sebashine-branly sebashine-branly marked this pull request as ready for review September 5, 2023 08:20
@sebashine-branly sebashine-branly requested a review from a team as a code owner September 5, 2023 08:20
@sebashine-branly sebashine-branly requested review from forstisabella and removed request for a team September 5, 2023 08:20
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! I'll merge it after the corresponding PR in the actions-destinations repo is complete.

@forstisabella forstisabella added the content-update updates to content that are not new features, includes grammar fixes, added notes label Oct 25, 2023
@forstisabella
Copy link
Contributor

Hi @sebashine-branly - as this has been open for a few months with no action, I'm going to close this for now. I'm still watching the corresponding PR in the action-destinations repo, and will reopen/merge this PR if that gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants