Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsValidValue method to stats package. #116

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Add IsValidValue method to stats package. #116

merged 3 commits into from
Jan 3, 2020

Commits on Jan 3, 2020

  1. Add IsValidValue method to stats package. 

    For programs which import opaque metrics from 3rd party APIs and
then pass those into the stats package, this will help them avoid
panics that result from passing in invalid values (such as structs
or maps) that the 3rd party API might have returned.
    Collin Van Dyck committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    a7cfcf1 View commit details
    Browse the repository at this point in the history

  2. Add MustValueOf func. 

    This inspects the return value of ValueOf, ideally.  Non-test
call-sites were changed to use MustValueOf(ValueOf(..)).
    Collin Van Dyck committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    ee9d0f4 View commit details
    Browse the repository at this point in the history

  3. Add identity return for ValueOf for Value

    Collin Van Dyck committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    b6261d2 View commit details
    Browse the repository at this point in the history